Code cleanup with regard to PR 414, operator overloads and default constructor for WebRequestMethodComposite#415
Merged
mathieucarbou merged 4 commits intomainfrom Mar 18, 2026
Merged
Conversation
mathieucarbou
requested review from
Copilot and
willmmiles
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
Adds/adjusts WebRequestMethodComposite comparison and move behavior to support method-composite usage across the server and examples.
Changes:
- Updates
WebRequestMethodCompositeoperators and adds explicit copy/move ctor/assignment implementations. - Propagates
std::moveforWebRequestMethodCompositethrough handlersetMethod()calls. - Fixes example sketches to reference
AsyncWebRequestMethod::HTTP_*constants.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebServer.cpp | Moves method into handlers when registering routes. |
| src/WebHandlerImpl.h | Moves method into _method in setMethod(). |
| src/ESPAsyncWebServer.h | Alters WebRequestMethodComposite operators; adds copy/move ctors and assignments. |
| src/AsyncJson.h | Moves method into _method in JSON handler setMethod(). |
| examples/HTTPMethodsWithESPIDF/HTTPMethodsWithESPIDF.ino | Updates method enum references to AsyncWebRequestMethod::HTTP_*. |
| examples/HTTPMethodsWithArduino/HTTPMethodsWithArduino.ino | Updates method enum references to AsyncWebRequestMethod::HTTP_*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willmmiles
requested changes
Mar 18, 2026
willmmiles
left a comment
willmmiles
left a comment
There was a problem hiding this comment.
Please avoid redefining the default constructors and operators -- the language builtins are almost always faster.
If the language requires explicit specification use =default to get the benefits of the internally optimized versions.
Member
Author
|
@willmmiles also added 2 commits to fix #414 based on your comment (#414 (comment)) plus another one I saw that already existed. |
mathieucarbou
changed the title
mathieucarbou
changed the title
mathieucarbou
changed the title
willmmiles
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.